-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hcp 4-axes indices as well #390
Conversation
Pull Request Test Coverage Report for Build 1341981122
💛 - Coveralls |
It looks much better now. The input hkl for hcp structures should be a 3x4 matrix so I just changed that.
@pmrv Thank you for including the 4-axes indices. The input hkl for hcp structures should be a 3x4 matrix so I have changed it in the file. |
Should I merge it? |
Have you tried it on the cluster once? Because I didn't. If it works, merge it. |
How do I try it on the cluster? It's not in the master branch yet. Can I try it without it being merged? |
Atomsk on the cluster is currently out-of-date. |
I found a few bugs testing it, I'll give it a try again once the conda package is updated. We have some older instructions here how to set up a dev environment, just replace the |
@prince-mathews Give this a try if it works for HCP Mg now.